Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some metadata to npm publishing #84

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Add some metadata to npm publishing #84

merged 1 commit into from
Apr 6, 2023

Conversation

stianjensen
Copy link
Member

It would be nice to include readme and license as well, but readme will be copied along automatically if we as part of the release step copy the top-level readme into the published folder (or add a secondary readme inside with release specific information).

And the license is just still missing, so I'll leave that for later.

It would be nice to include readme and license as well, but readme will
be copied along automatically if we as part of the release step copy the
top-level readme into the published folder (or add a secondary readme
inside with release specific information).

And the license is just still missing, so I'll leave that for later.
Copy link
Member

@sigvef sigvef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tried soft-linking the readme to the inner folder to see if that would help it make the cut for the release, but sadly not. Copying during the build step is probably an ok solution then.

@sigvef sigvef merged commit 386a176 into main Apr 6, 2023
@sigvef sigvef deleted the npm-metadata branch April 6, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants