Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surpress click handlers when fullscreen #87

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Surpress click handlers when fullscreen #87

merged 1 commit into from
Apr 7, 2023

Conversation

aleksanb
Copy link
Member

@aleksanb aleksanb commented Apr 7, 2023

Used for orbital controls ++

@aleksanb
Surpress click handlers when fullscreen
468e454 
Used for orbital controls ++
stianjensen
stianjensen approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@stianjensen stianjensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

At least now, we don't have any click handlers that are interesting while fullscreen.

@stianjensen stianjensen merged commit f410960 into main Apr 7, 2023
@stianjensen stianjensen deleted the click-fullscreen branch April 7, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stianjensen stianjensen stianjensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksanb @stianjensen