Repair stepOffset in sync.flash #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't find any traces of us actually having used stepOffset before, so I can't say for sure what the intended purpose was, but this makes it behave more how I was expecting it, letting you offset when in a beat/bar flashes occur. The trick is that we need the value for startStep to change exactly when we reach the step of its new value. That was out of sync without this fix, giving strange results.
aleksanb
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any traces of us actually having used stepOffset before, so I can't say for sure what the intended purpose was, but this makes it behave more how I was expecting it, letting you offset when in a beat/bar flashes occur.
The trick is that we need the value for startStep to change exactly when we reach the step of its new value. That was out of sync without this fix, giving strange results.