Expose demoNeedsRender flag #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase |
This lets us rerender the demo from "userland", which is a requirement for FlyControls.
sigvef
force-pushed
the
expose-demo-rendering-flag
branch
from
5ebbf97 to
876198c
Compare
trondkla
approved these changes
Jul 12, 2023
| @@ -588,7 +589,6 @@ export class Renin { | |||
| this.uiOldTime = this.uiTime; | |||
| this.uiTime = Date.now() / 1000; | |||
| this.uiDt += this.uiTime - this.uiOldTime; | |||
| let demoNeedsRender = false; | |||
There was a problem hiding this comment.
Should the default value be false too? Since it was false as standard before.
There was a problem hiding this comment.
Ah, I see it says = false at he bottom, so it seems like it will be correct :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose demoNeedsRender flag
This lets us rerender the demo from "userland", which is a requirement
for FlyControls.