Fixed #263 (#264)

ninject · Apr 12, 2022 · 9d02993 · 9d02993
1 parent 46673bc
commit 9d02993
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/...n/EnumerableDependenciesTests/WhenServiceRequestsUnconstrainedEnumerableOfDependencies.cs b/...n/EnumerableDependenciesTests/WhenServiceRequestsUnconstrainedEnumerableOfDependencies.cs
@@ -48,5 +48,14 @@ public void EmptyEnumerableIsResolvedIfElementTypeIsMissingBinding()
 
             children.Should().BeEmpty();
         }
+
+        [Fact]
+        public void EmptyEnumerableIsResolvedIfElementTypeIsMissingBindingEvenIsWasResoved()
+        {
+            var child = this.Kernel.Get<ChildA>();
+            var children = this.Kernel.Get<IEnumerable<ChildA>>();
+
+            children.Should().BeEmpty();
+        }
     }
-}
+}
diff --git a/src/Ninject/KernelBase.cs b/src/Ninject/KernelBase.cs
@@ -531,7 +531,7 @@ void UpdateRequest(Type service)
             {
                 if (handleMissingBindings && this.HandleMissingBinding(request))
                 {
-                    return this.Resolve(request, false);
+                    return this.Resolve(request);
                 }
 
                 if (request.IsOptional)
@@ -568,7 +568,7 @@ from binding in satisfiedBindings
             }
             else
             {
-                if (satisfiedBindings.Any(binding => !binding.IsImplicit))
+                if (satisfiedBindings.Any(binding => !binding.IsImplicit) || !handleMissingBindings)
                 {
                     satisfiedBindings = satisfiedBindings.Where(binding => !binding.IsImplicit);
                 }