Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor export svg to isolate actual file writing code. #1050

Merged
merged 1 commit into from
May 20, 2024

Conversation

cmeyer
Copy link
Collaborator

@cmeyer cmeyer commented May 15, 2024

This is minor refactoring to isolate the actual code which exports the SVG file. Refactoring like this allows for tests to run SVG exports easily. This was part of my attempt to evaluate #874 which attempts to fix #591. However, I've decided to abandon #874 for now - and I'm planning to add more notes to #591.

References:

@cmeyer cmeyer requested a review from lisham2000 May 15, 2024 19:30
@cmeyer
Copy link
Collaborator Author

cmeyer commented May 15, 2024

@lisham2000 since this affects code you may be working on, please let me know if you want me to merge this. Alternatively you can use "git cherry-pick" to add this commit to your own changes. If you think this will merge cleanly with your changes (or if you haven't started on your changes), please let me know and I'll merge this right away.

@cmeyer cmeyer merged commit 1f1397c into nion-software:master May 20, 2024
13 checks passed
@cmeyer cmeyer deleted the svg-refactor branch May 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting data items with forward slashes results in wrong filename
1 participant