Changing the SVG export to only require height an accept multiple units #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created ZoomMouseHandler, and an apply_fixed_zoom that takes a zoom target coordinate
…ra white background.
Adding zoom in/out buttons to toolbar.
Zoom-Tool - Zoom-By-Drag
Iss7 missing workspace controller
|
This doesn't look like it's ready for review, so this comment might be preliminary - but can you submit a PR for the "only require user to enter height" task separately from a PR for "allow user to specify units when exporting"? Thanks. |
|
Closing this due to the revaluation of pull request process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing SVG export to only consider height and maintain aspect ratio
Change SVG export to have multiple units