Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export results tabulated in popup #1072

Closed
wants to merge 5 commits into from

Conversation

KRLango
Copy link
Contributor

@KRLango KRLango commented Jun 18, 2024

This is for issue #749. It presents the results of exports in a popup showing which succeeded and which failed. For failed exports any error message is shown.

An option to open the folder where the exports are saved is also included for quickly getting to the outputs.

@Ion-e
Copy link

Ion-e commented Jun 19, 2024

Bug - Attempting to export an invalid export is reported as "success" in the dialog, however the export doesn't complete, please also note that there are no error messages thrown on the Outputs when the export fails.

Please also note that there no error messages thrown on the Outputs when the export succeeds, is this something we would want? @cmeyer

@KRLango KRLango marked this pull request as ready for review June 19, 2024 15:04
@cmeyer
Copy link
Collaborator

cmeyer commented Jun 19, 2024

Merged with changes.json, squashed, minor edit to commit message 899098e

Notes and future work:

  • You can get the UserInterface ui object using document_controller.ui. This fact isn't always used consistently in existing code...
  • Another note: document_controller is basically the window. It is named "controller" due to historical reasons.
  • The results dialog should probably be cleaned up to be centered after display (not sure how to do this, may need to measure outputs before-hand and estimate width).
  • The results dialog should also probably include a scroll area in case there are 100 output items to report.
  • An additional task is to move the "open file in explorer" code to Utility.py so it is common. It occurs in 3+ places right now.
  • I didn't add new issues for any of the "to-do" style items above.

@cmeyer cmeyer closed this Jun 19, 2024
@cmeyer
Copy link
Collaborator

cmeyer commented Jun 19, 2024

Bug - Attempting to export an invalid export is reported as "success" in the dialog, however the export doesn't complete, please also note that there are no error messages thrown on the Outputs when the export fails.

Please also note that there no error messages thrown on the Outputs when the export succeeds, is this something we would want? @cmeyer

The Output window is used inconsistently right now - so I'd say let's not worry about it for now until we have a consistent story for the Output window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants