Use list canvas item version 2 for data panel, optimized #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror). The errors are raised with invalid data. The tests do not raise errors unless thumbnails are computed. The new data panel will compute thumbnails more quickly and trigger the errors.
cmeyer
changed the title
This issue was revealed by the tests and the faster data panel. This fix just converts the RGB data to grayscale and then continues as normal. It is a hack but reasonable since it hasn't come up as a bug until now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit updates the image display to use the visible rect painting optimization. The next two commits are prep for the last commit, which changes the data panel to use the new list canvas item v2, with optimized drawing.
To test this, you will need nion-software/nionui#88
Possible test procedure:
DATA-PANEL-1. Test data panel functionality.
1.1. Data panel shows list of items and scroll bar, filling data panel width and height.
2.1. Display items scroll with scroll bar.
3.1. Display item is selected.
4.1. Display items in range are selected.
5.1. Command clicking should toggle selection.
6.1. Selected item should be deleted.
7.1. All selected items should be deleted.
8.1. Tool tip should be shown.
9.1. Display item should be shown in display panel.
10.1. Selected display item should change.
11.1. Selected display items should be extended up or down depending on key.
12.1. Selected display items should scroll.
13.1. Confirm no thumb appears in scroll bar.
14.1. Confirm thumb appears in scroll bar.