Update graphics inspector section to use ObservedListModel to catch c… #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges to the graphics list
|
I think #1219 should also be fixed by this |
cmeyer
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Other than the missing super.__init__(), this looks good. Any reason it is still a draft?
I'm not sure why mypy doesn't catch the missing super.init... but see this issue.
Also, note that flake8 --ignore E501 nion/swift/Inspector.py does not catch this issue either.
However, pylint nion/swift/Inspector.py it shows up as "nion/swift/Inspector.py:3199:4: W0231: init method from base class 'Handler' is not called (super-init-not-called)". However it is mixed into 100's of other lint errors. Oh well.
|
Squashed/merged here 2d73324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hanges to the graphics list
#1210