Fix #1203. Eliminate use of data sampling to calculate complex display limits. #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omplex display limits. The sample size was 200 and in no way could be representative of an arbitrary complex valued image displayed in log-absolute. This was probably done for perceived performance; but modern processors make the performance issue minimal. So do not sample; just use the full range until a good general sampling solution is implemented.
Brow71189
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Generally this looks fine to me. The only issue I can see is that removing access to xdata from calculate_display_range will make it harder to implement more sophisticated algorithms for auto display range that don't just look at the data min and max.
But maybe we would just implement that in the DisplayRangeProcessor class anyway, in which is case it is not an issue.
|
Yes, we can add that back when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample size was 200 and in no way could be representative of an
arbitrary complex valued image displayed in log-absolute. This was probably
done for perceived performance; but modern processors make the performance
issue minimal. So do not sample; just use the full range until a good
general sampling solution is implemented.