Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_spm_globals added #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oliviakowalczyk
Copy link

  • Added get_spm_globals to spm_funcs.py.

Copy link

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I just left one comment on the code, anticipating potential uses.

Although the title of the PR and comment are informative, a better PR description would be great for other developers to understand what was done and why. Similarly, for each commit message (there's only one here, so not much to confuse anyone, but sometimes PRs require lots of commits).

for vol in range(data.shape[-1]):
glob = spm_global(data[..., vol])
spm_vals.append(glob)
return spm_vals # Return the result.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the type of spm_vals?

If you read the docstring (line 54 above) it says array, which is very unclear but seems to refer to a numpy.array, however, you return a basic list here. Consider converting it to array before returning or else downstream methods could fail. For instance, with the current implementation you would not be able to do:

average_spm = get_spm_globals(nifti_file).mean()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants