-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added spm_global function #37
base: main
Are you sure you want to change the base?
added spm_global function #37
Conversation
spm_funcs.py
Outdated
img = nib.load(fname) # Load image | ||
data = img.get_fdata() # Get image data | ||
|
||
spm_values = np.asarray([]) # create empty array for spm values per volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this line - you aren't using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course, thank you. I started a for loop then converted to a list comprehension and forgot to del. Fixing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted one unnecssary line, as per your comment
spm_funcs.py
Outdated
img = nib.load(fname) # Load image | ||
data = img.get_fdata() # Get image data | ||
|
||
spm_values = np.asarray([]) # create empty array for spm values per volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course, thank you. I started a for loop then converted to a list comprehension and forgot to del. Fixing...
a question: I have now commited and pushed changes, is that then part of the same pull request or do I have to close this one and create a new one? |
You make a pull request from a branch in your fork - in this case |
please accept changes to spm_func.py with changes: added code for spm_spm_global sfunction :)