Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Increase minimal nibabel required version to 3.0.1 #80

Closed
wants to merge 1 commit into from

Conversation

arokem
Copy link
Collaborator

@arokem arokem commented Feb 25, 2020

I think that this should help resolve CI errors in #76,#77, #78, etc.

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     MAINT: Increase minimal nibabel required version to 3.0.1

Powered by Pull Assistant. Last update 6de9387 ... 6de9387. Read the comment docs.

@josephmje
Copy link
Collaborator

our smriprep version also requires nibabel 3.0.0rc1. we may need to bump this up as well but i think there are changes to the way output spaces are handled in the new version.

@arokem
Copy link
Collaborator Author

arokem commented Feb 25, 2020

Looks like I am getting some mysterious errors from nipype now. Anyone know these?

@oesteban
Copy link
Member

I think @josephmje is right. Will bump smriprep before the meeting today.

@ghost
Copy link

ghost commented Feb 27, 2020

Warnings are found on analyzing the commit 6de9387.

1 warning:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@oesteban
Copy link
Member

oesteban commented Mar 9, 2020

Solved via #83

@oesteban oesteban closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants