ENH: Use NumPy's Generator class as a replacement for RandomState
#141
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
UseNumpyRandomGenerator
branch
from
3d8081d
to
464c288
Compare
arokem
reviewed
Mar 24, 2024
jhlegarreta
force-pushed
the
UseNumpyRandomGenerator
branch
2 times, most recently
from
d77d289
to
eae871f
Compare
oesteban
reviewed
Mar 28, 2024
Use NumPy's `Generator` class as a replacement for `RandomState` for random variarte generation methods. `RandomState` was deprecated in NumPy 1.17.0. Take advantage of the commit to document better the use of the `seed` parameter. Documentation: https://numpy.org/doc/stable/reference/random/new-or-different.html#what-s-new-or-different https://numpy.org/doc/stable/reference/random/generated/numpy.random.seed.html
jhlegarreta
force-pushed
the
UseNumpyRandomGenerator
branch
from
eae871f
to
b0e53e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use NumPy's
Generatorclass as a replacement forRandomStatefor random variarte generation methods.RandomStatewas deprecated in NumPy 1.17.0.Take advantage of the commit to document better the use of the
seedparameter.Documentation:
https://numpy.org/doc/stable/reference/random/new-or-different.html#what-s-new-or-different
https://numpy.org/doc/stable/reference/random/generated/numpy.random.seed.html