Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

DOC: Improve the copyright notice information in the LICENSE file #235

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

jhlegarreta
Copy link
Collaborator

Improve the copyright notice information in the LICENSE file: make the notice specific to this repository and avoid any variability in the notices by removing the placeholders:

  • Use the original year (2021) in which works were first released.
  • Use the NiPreps name and email address in LICENSE file.
  • Remove the explanation related to the placeholders.

Apply the above changes to the copyright notices across source files.

LICENSE Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.08%. Comparing base (b1d9928) to head (a29ab26).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   63.97%   64.08%   +0.11%     
==========================================
  Files          18       18              
  Lines         905      905              
  Branches      154      117      -37     
==========================================
+ Hits          579      580       +1     
  Misses        282      282              
+ Partials       44       43       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta jhlegarreta force-pushed the IncreaseCopyrightNoticeConsistency branch 2 times, most recently from ac29057 to 1db693e Compare October 5, 2024 23:42
@jhlegarreta
Copy link
Collaborator Author

Have been thinking and reading more about this:

So despite the comment about the year in the 17 U.S. Code § 401 mentioned in https://opensource.stackexchange.com/a/5779, it looks like dropping the year would be OK as mentioned at the Tech Monitoring meeting on Oct 1 2024. Did not add a reference to the LICENSE file though, and followed what the instructions say. the LICENSE file contains anyways the same information as the URL that is pointed on every file.

LICENSE Outdated Show resolved Hide resolved
NOTICE Outdated Show resolved Hide resolved
effigies
effigies previously approved these changes Oct 6, 2024
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple minor suggestions.

jhlegarreta and others added 2 commits October 7, 2024 09:50
Improve the copyright notice information:
- Introduce a `NOTICE` file to hold the copyright information: state the
  original year (2021) in which works were first released and use
  `-present` to avoid any need to update the year at every release.
- Remove the license application instructions from the `LICENSE` file.
- Remove the copyright year from every other source file.
Update `NOTICE` to contain the Apache license notice paragraph.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@jhlegarreta jhlegarreta force-pushed the IncreaseCopyrightNoticeConsistency branch from 2189cf5 to 0a1f560 Compare October 7, 2024 13:53
effigies
effigies previously approved these changes Oct 7, 2024
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Given that I proposed removing the license appendix, I'll let someone else merge, if they agree.

oesteban
oesteban previously approved these changes Oct 17, 2024
NOTICE Outdated Show resolved Hide resolved
@jhlegarreta jhlegarreta dismissed stale reviews from oesteban and effigies via e91feaa October 18, 2024 07:43
jhlegarreta and others added 2 commits October 18, 2024 03:45
The `NOTICE` file text is not a repetition of the license banner, but
clarifications about the licensing of the code (e.g., if in the past had
other licenses, or if it derives from pre-exiting code).

Thus, remove the license information and edit the text to reflect the
copyright of the code.

Co-authored-by: Oscar Esteban <code@oscaresteban.es>
Specify years in the copyright text of the `NOTICE` file.
@jhlegarreta jhlegarreta force-pushed the IncreaseCopyrightNoticeConsistency branch from e91feaa to 8340d37 Compare October 18, 2024 07:50
oesteban
oesteban previously approved these changes Oct 18, 2024
NOTICE Outdated Show resolved Hide resolved
Remove "present" as ending year from copyright NOTICE: it 
does not add relevant information/it is implicit.

Co-authored-by: Oscar Esteban <code@oscaresteban.es>
@oesteban oesteban merged commit bc48575 into nipreps:main Oct 23, 2024
7 of 8 checks passed
@jhlegarreta jhlegarreta deleted the IncreaseCopyrightNoticeConsistency branch October 23, 2024 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants