This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
ENH: Allow simulating multi-fiber voxels #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 19 19
Lines 905 905
Branches 112 112
=======================================
Hits 599 599
Misses 264 264
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Add a script to plot the signal estimated by the GP as well as the error data generated by the error analysis script. Add the necessary helper functions to the signal visualization module to plot the estimated signal as a surface. Modify the signal visualization error plotting method to optionally accept the color the figure size parameters. Add methods to the the signal simulation module in order to serialize the dMRI data. Refactor the the the signal simulation module to: - Allow the dMRI signal generation method to generate evals randomly if not provided. - Allow reusing the polar random angle generation utility. - Allow the single tensor method to accept a random generator for the sake of reproducibility. - Set the `zip` function `strict` parameter to `True` as we want all iterables to have the same length. - Create a method to simulate a single-fiber multivoxel signal given the gradient table and the rest of the necessary parameters. Modify the error analysis script to: - Reuse the `EddyMotionGPR` instance: factor it out from the CV function, as the instance does not change across folds and repeats. - Save the simulated signal and gtab. - Predict and save the signal of the GP estimation. - Save the simulated SNR to the CV scores data file. Since `None` indicates no noise, modify the `pandas` serialization method arguments so that `None` is not considered as a missing value. Take advantage of the commit to rename the `evals1` argument to `evals` in the error analysis script.
Rename the error analysis script to honor better its purpose.
Rename the `EddyMotionGPR` instance to honor better its classname.
Add a script to plot the signal estimated by the GP as well as the error data generated by the error analysis script. Add the necessary helper functions to the signal visualization module to plot the estimated signal as a surface. Modify the signal visualization error plotting method to optionally accept the color the figure size parameters. Add methods to the the signal simulation module in order to serialize the dMRI data. Refactor the the the signal simulation module to: - Allow the dMRI signal generation method to generate evals randomly if not provided. - Allow reusing the polar random angle generation utility. - Allow the single tensor method to accept a random generator for the sake of reproducibility. - Set the `zip` function `strict` parameter to `True` as we want all iterables to have the same length. Modify the error analysis script to: - Reuse the `EddyMotionGPR` instance: factor it out from the CV function, as the instance does not change across folds and repeats. - Save the simulated signal and gtab. - Predict and save the signal of the GP estimation. - Save the simulated SNR to the CV scores data file. Since `None` indicates no noise, modify the `pandas` serialization method arguments so that `None` is not considered as a missing value. Take advantage of the commit to rename the `evals1` argument to `evals` in the error analysis script.
Allow simulating multi-fiber voxels.
jhlegarreta
force-pushed
the
AllowMutliFiberVoxels
branch
from
075fa16 to
2296b88
Compare
|
Closing in favor of #247. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow simulating multi-fiber voxels.