-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: reference workflow 2.0 #38
ENH: reference workflow 2.0 #38
Conversation
aa1dffc
to
9046e01
Compare
The checks that are failing are only doing so on the @oesteban - I don't know how to proceed with this, but the circleCI checks are looking good with the workflow completing without errors. WDYT? |
@oesteban - I think these changes are good to go; can we address the pip build before merging? |
Okay, you should be able to rebase or merge |
Co-authored-by: Oscar Esteban <code@oscaresteban.es>
3c411cd
to
b113753
Compare
The removal of Fingers crossed that this time we get a clean sheet |
Ding Ding Ding! We have a winner. I've noticed that our ME pipeline might need some work before release (e.g. the masking is still using |
Changes proposed in this pull request
Unlike in #35, this reference workflow creates one reference image per BOLD run. In future, it would be good to implement something as in nipreps/nibabies#15 where reference images are calculated for similar BOLD runs (same PE, readout time) but this can be added at a later stage.
Documentation that should be reviewed