-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resampling funcs to standard spaces fails in 1.4.0a0 #1626
Comments
Hi again, Here's a screenshot from Running Note that my original call to fmriprep didn't ask for MNI152NLin6Asym under |
@markushs Thanks so much for tracking this down! We're lucky to have you trying out the pre-release. |
Okay, I can see this happening also on my settings. The
So I guess I missed some connection to the ApplyTransforms node. |
This PR fixes nipreps#1626. The ``transforms`` input to ``MultyApplyTransforms`` had not been updated to get fed by the ``KeySelect`` interface that demultiplexes parameterized fields. With great thanks to @markushs for his invaluable help catching this.
@markushs you are the goalkeeper of this release. Thank you so much. |
@markushs pre-release 1.4.0a1 should post within the next couple of hours. Can I ask you to give it a try and confirm this problem has been addressed? |
@oesteban Yes, everything seems to work much better now! One observation though: the funcs in both MNI-spaces come out identical even though different |
Are they identical bitwise or visually? |
They should have different resolutions, for instance. |
So, the preprocessed funcs are both in native resolution (3.027 x 3.027 x 3 mm in both MNI spaces). The preprocessed BOLD time series are identical voxel-by-voxel to the 6th digit at least. |
Sorry for not being of more help here, but I can at least confirm that the inputs to |
Thanks for the heads up, again :) |
Hi,
You might be aware of this, but resampling of funcs to standard spaces produces strange results in in 1.4.0.a0. Here's an example (
anat/sub-XX_space-MNI152Nlin2009cAsym_desc-preproc_T1w
in red, overlaid on onefunc/*_space-MNI152NLin2009cAsym_boldref
)Here's just the
func/*_space-MNI152NLin2009cAsym_boldref
I see this error in all subjects I've run through 1.4.0.a0 (to get around #1615 after implementing #1603), and for both MNI152NLin2009cAsym and MNI152NLin6Asym. Same data has been processed in previous versions of fmriprep without these issues.
I know that 1.4.0.a0 is a pre-release, so sorry if this an already known issue planned to be fixed for the "official" release.
The text was updated successfully, but these errors were encountered: