Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix label on CI step "Skipping doc building job" #1564

Merged

Conversation

ariveradompenciel
Copy link
Contributor

@ariveradompenciel ariveradompenciel commented Apr 1, 2019

Changes proposed in this pull request

Fixes #1563
Changed echo "Skipping pytest job" to "Skipping doc building job"

Documentation that should be reviewed

N/A

…ip tests][skip docs][skip ds005][skip ds054][skip ds210]
@welcome
Copy link

welcome bot commented Apr 1, 2019

Thanks for opening this pull request! We have detected this is the first time for you to contribute to fMRIPrep. Please check out our contributing guidelines.
We invite you to list yourself as a fMRIPrep contributor, so if your name is not already mentioned, please modify the .zenodo.json file with your data right above Russ' entry. Example:

{
   "name": "Contributor, New FMRIPrep",
   "affiliation": "Department of fMRI prep'ing, Open Science Made-Up University",
   "orcid": "<your id>"
},
{
   "name": "Poldrack, Russell A.",
   "affiliation": "Department of Psychology, Stanford University",
   "orcid": "0000-0001-6755-0259"
},

Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

.circleci/config.yml Outdated Show resolved Hide resolved
…line 308, and reverted to original print statement in line 224 [skip tests][skip docs][skip ds005][skip ds054][skip ds210]
Copy link
Collaborator

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the correct print statement is used for pytest and docs

@effigies
Copy link
Member

effigies commented Apr 3, 2019

Great! @ariveradompenciel Would you like to add yourself to the .zenodo.json file, as described in #1564 (comment)?

@effigies effigies changed the title [CI] Changed echo "Skipping pytest job" to "Skipping doc building job" [CI] Fix label on CI step "Skipping doc building job" May 2, 2019
@effigies effigies merged commit f7048fb into nipreps:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect circleci print statement
4 participants