Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add major/minor versions to base workflow name #2716

Merged
merged 1 commit into from
Mar 3, 2022
Merged

ENH: Add major/minor versions to base workflow name #2716

merged 1 commit into from
Mar 3, 2022

Conversation

effigies
Copy link
Member

Closes #2712.

@effigies effigies added this to the 22.0.0 milestone Feb 17, 2022
@effigies
Copy link
Member Author

From the logs:

220217-16:05:48,424 nipype.workflow INFO:
	 [Node] Setting-up "fmriprep_21_0_wf.single_subject_01_wf.func_preproc_task_mixedgamblestask_run_02_wf.func_derivatives_wf.ds_bold_surfs" in "/scratch/fmriprep_21_0_wf/single_subject_01_wf/func_preproc_task_mixedgamblestask_run_02_wf/func_derivatives_wf/_key_fsnative/ds_bold_surfs".
220217-16:05:48,541 nipype.workflow INFO:
	 [Node] Setting-up "_ds_bold_surfs0" in "/scratch/fmriprep_21_0_wf/single_subject_01_wf/func_preproc_task_mixedgamblestask_run_02_wf/func_derivatives_wf/_key_fsnative/ds_bold_surfs/mapflow/_ds_bold_surfs0".
220217-16:05:48,610 nipype.workflow INFO:
	 [Node] Running "_ds_bold_surfs0" ("fmriprep.interfaces.DerivativesDataSink")
220217-16:05:48,703 nipype.workflow INFO:
	 [Node] Finished "_ds_bold_surfs0".
220217-16:05:48,706 nipype.workflow INFO:
	 [Node] Setting-up "_ds_bold_surfs1" in "/scratch/fmriprep_21_0_wf/single_subject_01_wf/func_preproc_task_mixedgamblestask_run_02_wf/func_derivatives_wf/_key_fsnative/ds_bold_surfs/mapflow/_ds_bold_surfs1".
220217-16:05:48,775 nipype.workflow INFO:
	 [Node] Running "_ds_bold_surfs1" ("fmriprep.interfaces.DerivativesDataSink")
220217-16:05:48,868 nipype.workflow INFO:
	 [Node] Finished "_ds_bold_surfs1".
220217-16:05:48,871 nipype.workflow INFO:
	 [Node] Finished "fmriprep_21_0_wf.single_subject_01_wf.func_preproc_task_mixedgamblestask_run_02_wf.func_derivatives_wf.ds_bold_surfs".
220217-16:05:48,871 nipype.workflow INFO:
	 [Job 344] Completed (fmriprep_21_0_wf.single_subject_01_wf.func_preproc_task_mixedgamblestask_run_02_wf.func_derivatives_wf.ds_bold_surfs).

Looks sensible.

oesteban
oesteban approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea - thanks!

@oesteban oesteban merged commit f1a9f2a into nipreps:master Mar 3, 2022
@mgxd mgxd mentioned this pull request Mar 25, 2022
Closed
@effigies effigies deleted the enh/versioned_workflow_dir branch March 25, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.0.0
Development

Successfully merging this pull request may close these issues.

Add major/minor versions to base workflow name
2 participants
@effigies @oesteban