MAINT: Normalize code style of workflows.confounds

[oesteban]

Changes proposed in this pull request

Documentation that should be reviewed

[effigies]

If this is just black, merge at will.

[effigies]

Or even just push the commit directly to master.

[oesteban]

If this is just black, merge at will.

It's just black, but for some reason, it didn't normalize the single-quotes to double-quotes. So I did it manually and want to check I did not screw up :)

[effigies]

We disabled the quote normalization in config a while back.

[oesteban]

We disabled the quote normalization in config a while back.

I've looked through setup.cfg in an attempt to find that but now I see it is in the pyproject.toml file.

Is there a particular reason for this? We have used both styles indistinctly, I would understand if we were following some convention...

[effigies]

The reason is mostly that black gets applied sometimes and it became hard to review PRs that mixed semantic changes and style fixes in unrelated portions of the code.

[oesteban]

Makes sense. We could normalize though that a PR with only stylistic changes is submitted and the subsequent PR operates off of the styled branch. WDYT?

(that's actually what is going on in this PR, which I'm sending to then attack #2621 without style differences)

[effigies]

Yup, that's fine and what I'd prefer. Or even just separating the style commits.

[oesteban]

Seems like ds210 fails for some other reason - https://app.circleci.com/pipelines/github/nipreps/fmriprep/678/workflows/1802c485-cf84-4fbe-9161-9734fa71a532/jobs/3731