Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Plot histogram of T2* values in gray-matter mask #2778

Merged
merged 9 commits into from
May 17, 2022

Conversation

effigies
Copy link
Member

Changes proposed in this pull request

Closes #2541. I think we should also show the gray-matter mask in the T2*-boldref map immediately above the histogram.

Documentation that should be reviewed

Working on the OHBM poster should provide some images/text that can be added to the docs.

effigies added 7 commits May 15, 2022 14:15
Keep separate from init_bold_t2s_wf to avoid possible ordering concerns,
for example, if the T2* map is ever needed to calculate the BOLD-T1w
transform needed to resample the gray matter mask back into BOLD space.
@effigies
Copy link
Member Author

Example histogram from CI (so registration is intentionally sloppy for speed). Probably makes sense to clip at 0-100ms. Are 2ms bins acceptable, or should we aim for 1ms or even smaller? We could probably clip at 0-80ms and do 0.5ms bins without making the bars annoyingly thin.

sub-02_task-cuedSGT_run-01_desc-t2starhist_bold

Now that we've got somewhere to start, I'll be running on original data with normal settings this evening to verify that we see reasonable values.

cc @javiergcas

@effigies
Copy link
Member Author

I do have WM and CSF masks as well, if it would be helpful, rather than cluttering to plot these histograms together. See https://seaborn.pydata.org/generated/seaborn.histplot.html for options for dealing with multiple histograms.

@effigies effigies force-pushed the enh/t2s_histograms branch from d7ca442 to b3ff2d5 Compare May 16, 2022 15:45
@effigies
Copy link
Member Author

t2star_reports

@effigies effigies merged commit 3ce5ec9 into nipreps:master May 17, 2022
@effigies effigies deleted the enh/t2s_histograms branch May 17, 2022 18:24
@effigies
Copy link
Member Author

Fixes can come in future PRs.

@effigies effigies added this to the 22.0.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-echo reporting: histogram of T2* values in gray-matter mask
1 participant