-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Plot histogram of T2* values in gray-matter mask #2778
Conversation
Keep separate from init_bold_t2s_wf to avoid possible ordering concerns, for example, if the T2* map is ever needed to calculate the BOLD-T1w transform needed to resample the gray matter mask back into BOLD space.
Example histogram from CI (so registration is intentionally sloppy for speed). Probably makes sense to clip at 0-100ms. Are 2ms bins acceptable, or should we aim for 1ms or even smaller? We could probably clip at 0-80ms and do 0.5ms bins without making the bars annoyingly thin. Now that we've got somewhere to start, I'll be running on original data with normal settings this evening to verify that we see reasonable values. cc @javiergcas |
I do have WM and CSF masks as well, if it would be helpful, rather than cluttering to plot these histograms together. See https://seaborn.pydata.org/generated/seaborn.histplot.html for options for dealing with multiple histograms. |
d7ca442
to
b3ff2d5
Compare
Fixes can come in future PRs. |
Changes proposed in this pull request
Closes #2541. I think we should also show the gray-matter mask in the T2*-boldref map immediately above the histogram.
Documentation that should be reviewed
Working on the OHBM poster should provide some images/text that can be added to the docs.