STY: Apply pyupgrade suggestions #3147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3147 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 53 53
Lines 3914 3916 +2
=======================================
+ Hits 1957 1958 +1
- Misses 1957 1958 +1 ☔ View full report in Codecov by Sentry. |
|
I want to hold off on this until the full release, then we'll probably just do what we're doing over in smriprep. We can take care of pyupgrade, flake8, and all that in a single PR. |
pyupgrade --py310-plus Also manually change a few `.format()` calls to f-strings.
DimitriPapadopoulos
force-pushed
the
pyupgrade
branch
from
673d9b0 to
e09e36a
Compare
effigies
added a commit
that referenced
this pull request
Feb 5, 2024
Follow-up to nipreps/smriprep#397. This should replace #3185 and #3147. I would review this commit-by-commit, and skip c0f2183, which was a pretty safe run of `ruff format` and `ruff --fix`. It's dominated by quote changes, so I would ignore it. Everything else could stand a review.
|
I think this should be covered by ruff now. |
|
Not entirely. For example, switching to f-strings is not covered by ruff (pyupgrade rules). |
|
Ah, do you want to go ahead and re-upgrade? Note that |
|
Let me have a look first:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
pyupgrade --py310-plusAlso manually change a few
.format()calls to f-strings.