[RTM] RF: Separate BOLD reference generation from head-motion correction #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
approved these changes
Aug 10, 2017
| """Generate a reference BOLD image for a series | ||
|
|
||
| This image is the target of head-motion-correction, and the subject of distortion | ||
| correction and registration to T1w and template spaces. |
There was a problem hiding this comment.
Are you planning on adding the workflow generation code within #638 or should we already require ourselves to write the graph whenever we add a new workflow? (even for small ones like this).
There was a problem hiding this comment.
The plan was to get the docstring right in whichever PR comes second, since there are going to be conflicts either way.
| name='outputnode') | ||
|
|
||
| # Simplify manually setting input image | ||
| if bold_file is not None: |
| 'ref_image_brain', 'movpar_file', 'n_volumes_to_discard', | ||
| 'bold_mask_report']), name='outputnode') | ||
| outputnode = pe.Node( | ||
| niu.IdentityInterface(fields=['xforms', 'bold_hmc', 'bold_split', 'movpar_file']), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #253, constructing a mean BOLD image would require a reference from each run to be created and merged. This PR takes a first step toward that end by separating reference generation from HMC.
It is set up so that a list of workflows could be easily generated from a list of BOLD images, but at the moment, it's simply moved to the start of
init_func_preproc_wf.