Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update niworkflows pin to support newer ANTs releases #1047

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

esavary
Copy link
Member

@esavary esavary commented Jan 26, 2023

@effigies
Copy link
Member

ERROR: Cannot install mriqc and mriqc[all]==22.0.7.dev12+gba1d9af because these package versions have conflicting dependencies.

The conflict is caused by:
    mriqc[all] 22.0.7.dev12+gba1d9af depends on niworkflows~=1.7.1
    nirodents 0.2.7 depends on niworkflows~=1.5.2
    mriqc[all] 22.0.7.dev12+gba1d9af depends on niworkflows~=1.7.1
    nirodents 0.2.6 depends on niworkflows~=1.5.2

I think we've really hamstrung ourselves with ~=. I think we need to go back to >= for all libraries. @mgxd has been playing with pip-tools lately and might have a workflow that will allow us to avoid situations like this while still pinning versions for deployment.

@oesteban
Copy link
Member

For the time being, I just pushed a new release of nirodents. Let's bring this up in tomorrow's meeting.

@oesteban
Copy link
Member

Finally, building - I'm merging this.

@oesteban oesteban merged commit 35f83f7 into nipreps:master Feb 27, 2023
@welcome
Copy link

welcome bot commented Feb 27, 2023

Thanks for opening this pull request and congratulations for taking it to the finish line! It looks like this is your first time contributing to MRIQC. 😄
We invite you to list yourself as an MRIQC contributor. To learn more about what that entails and how we credit our contributors, please check out the contributing guidelines. If your name is not already on the list, please insert it, in alphabetical order of (i) lastname and (ii) firstname, into the .maint/CONTRIBUTORS.md file.
Of course, if you want to opt-out this time, there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants