ENH: Large overhaul of the functional workflow w/focus on ME-EPI #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Nov 15, 2023
effigies
reviewed
Nov 15, 2023
effigies
reviewed
Nov 15, 2023
oesteban
force-pushed
the
fix/multi-echo-bold
branch
from
1afe856
to
88b2729
Compare
oesteban
force-pushed
the
fix/multi-echo-bold
branch
from
88b2729
to
e298a88
Compare
oesteban
force-pushed
the
fix/multi-echo-bold
branch
from
1c4a71b
to
5795b3a
Compare
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
oesteban
force-pushed
the
fix/multi-echo-bold
branch
2 times, most recently
from
98f619b
to
a87b680
Compare
oesteban
force-pushed
the
fix/multi-echo-bold
branch
from
a87b680
to
14712ed
Compare
|
Seems to be performing as expected, both on circle (all of them se-epi) and locally (me-epi). |
effigies
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
LGTM. Mainly checked the new SelectEcho interface and the synthstrip workflow. Most of the rest looks like necessary plumbing, but it would take me more time than it's worth to acquaint myself with the workflow and verify each one. If the workflow is running, that seems like a good sign that they worked.
Yes, those are the only things with reuse potential from fMRIPrep, and candidates for upsourcing into niworkflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors MRIQC to handle ME-EPI better. Incidentally, it also includes brain extraction (on the first echo, or single echo) with SynthStrip.
Specific changes:
Resolves: #773.
Resolves: #1152.
Resolves: #1028.