[FIX] Fixes greedy participant selection #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the possibility of using the star (*) wildcard to select participants with the `--participant_label` argument. Before this, the default was using the greedy search. Now, ``` mriqc data/ out/ participant --participant_label 32322A ``` will match only `sub-32322A`. And ``` mriqc data/ out/ participant --participant_label 32322A* ``` will match `sub-32322A`, `sub-32322AB`, etc. As well as: ``` mriqc data/ out/ participant --participant_label "*32322A" ``` that will match `sub-32322A` and `sub-032322A`, but won't match `sub-32322AB`. **Please note the use of quotes so that the shell does not expand the star**. Finally, ``` mriqc data/ out/ participant --participant_label "*32322A*" ``` will match all previous examples (`sub-32322A`, `sub-032322A`, and `sub-032322AB`). Close nipreps#385
|
I'm minting a new release of pybids that fixes the default greedy behavior.
It should be ready soon.
…On Tue, Mar 14, 2017 at 3:31 PM, Oscar Esteban ***@***.***> wrote:
Adds the possibility of using the star (*) wildcard to select participants
with the --participant_label argument. Before this, the default was
using the greedy search.
Now,
mriqc data/ out/ participant --participant_label 32322A
will match only sub-32322A. And
mriqc data/ out/ participant --participant_label 32322A*
will match sub-32322A, sub-32322AB, etc. As well as:
mriqc data/ out/ participant --participant_label "*32322A"
that will match sub-32322A and sub-032322A, but won't match
sub-32322AB.
*Please note the use of quotes so that the shell does not expand the star*
.
Finally,
mriqc data/ out/ participant --participant_label "*32322A*"
will match all previous examples (sub-32322A, sub-032322A, and
sub-032322AB).
Close #385 <#385>
------------------------------
You can view, comment on, or merge this pull request online at:
#426
Commit Summary
- [FIX] Fixes greedy participant selection
File Changes
- *M* mriqc/utils/bids.py
<https://github.com/poldracklab/mriqc/pull/426/files#diff-0> (34)
Patch Links:
- https://github.com/poldracklab/mriqc/pull/426.patch
- https://github.com/poldracklab/mriqc/pull/426.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#426>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOkpzpAg2JxNNgvMdhVxum2Q3rivSaYks5rlxUpgaJpZM4MdPT2>
.
|
|
Ok, shouldn't be hard to roll this back. Let's go ahead with this fix, and when pybids fixes this we'll roll this back. |
|
After upgrading pybids and applying #427, this problem seems to keep happening. I've tried this branch with the new pybids-0.1.0 and works as expected. Merging in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility of using the star (*) wildcard to select participants
with the
--participant_labelargument. Before this, the default wasusing the greedy search.
Now,
will match only
sub-32322A. Andwill match
sub-32322A,sub-32322AB, etc. As well as:that will match
sub-32322Aandsub-032322A, but won't matchsub-32322AB. Please note the use of quotes so that the shelldoes not expand the star.
Finally,
will match all previous examples (
sub-32322A,sub-032322A, andsub-032322AB).Close #385