-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Sanitize inputs #687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to connect the report from the Sanitize interface to the final report?.
requirements.txt
Outdated
@@ -1,3 +1,3 @@ | |||
numpy>=1.12.0 | |||
niworkflows>=0.2.7 | |||
git+https://github.com/chrisfilo/niworkflows.git@21c0647bb7e42938e947334ab8c474c011fe3484#egg=niworkflows-0.3.1-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are planning on merging nipreps/niworkflows#221 and release first, so the requirements will finally be pinned to that new release, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - that's why this PR is still marked as WIP.
I don't know the MRIQC reporting framework well enough to assess how hard this would be. I can at least open an issue for this. |
Ready to merge. |
Could you roll back the latest commit? Since MRIQC has the automated script to update the changelog, this is not necessary anymore. (supposing that your origin remote points to your fork of mriqc): git reset --hard HEAD^
git push origin +fix/sanitize_inputs |
cc85de2
to
5b41af8
Compare
done |
Closes #684