Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use PyBIDS 0.9.2+ via niworkflows PR #796

Merged
merged 7 commits into from
Jul 12, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Jul 9, 2019

Closes #776.

@effigies
Copy link
Member Author

effigies commented Jul 9, 2019

Travis failure is just whining about the URL in setup. Will be resolved once niworkflows has a release.

@effigies effigies force-pushed the dep/pybids_0.9 branch 2 times, most recently from 4dd7655 to f9416e2 Compare July 11, 2019 19:32
@effigies
Copy link
Member Author

@oesteban I suspect this is something you'll know more about:

Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
  File "/usr/local/miniconda/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/miniconda/lib/python3.7/site-packages/mriqc/bin/mriqc_run.py", line 418, in init_mriqc
    wf_list.append(build_workflow(dataset[mod], mod, settings=settings))
  File "/usr/local/miniconda/lib/python3.7/site-packages/mriqc/workflows/core.py", line 25, in build_workflow
    workflow = fmri_qc_workflow(dataset, settings=settings)
  File "/usr/local/miniconda/lib/python3.7/site-packages/mriqc/workflows/functional.py", line 111, in fmri_qc_workflow
    ema = epi_mni_align(settings)
  File "/usr/local/miniconda/lib/python3.7/site-packages/mriqc/workflows/functional.py", line 718, in epi_mni_align
    template_resolution=2, ),
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/interfaces/mixins/reporting.py", line 32, in __init__
    super(ReportCapableInterface, self).__init__(**kwargs)
  File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/interfaces/mni.py", line 100, in __init__
    super(RobustMNINormalization, self).__init__(**inputs)
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/interfaces/base/core.py", line 175, in __init__
    self.inputs = self.input_spec(**inputs)
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/interfaces/base/specs.py", line 67, in __init__
    super(BaseTraitedSpec, self).__init__(**kwargs)
  File "/usr/local/miniconda/lib/python3.7/site-packages/traits/trait_handlers.py", line 172, in error
    value )
traits.trait_errors.TraitError: The 'moving' trait of a RobustMNINormalizationInputSpecRPT instance must be 'T1w' or 'boldref', but a value of 'bold' <class 'str'> was specified.

We can naively replace bold with boldref here:

https://github.com/poldracklab/mriqc/blob/f38b344655e37b25e7e8f6af373f8c361874a7b8/mriqc/workflows/functional.py#L710

But I'm not sure if that's actually appropriate.

@oesteban
Copy link
Member

It is actually necessary - nipreps/niworkflows#368

I forgot to check on MRIQC when merged that PR.

@effigies
Copy link
Member Author

It is actually necessary - poldracklab/niworkflows#368

I forgot to check on MRIQC when merged that PR.

To be clear, I should change that to boldref, or we need to restore bold to the interface options?

@oesteban
Copy link
Member

oesteban commented Jul 12, 2019 via email

@effigies effigies changed the title MAINT: Use PyBIDS 0.9.x via niworkflows PR MAINT: Use PyBIDS 0.9.2+ via niworkflows PR Jul 12, 2019
@oesteban oesteban merged commit 255c882 into nipreps:master Jul 12, 2019
@effigies effigies deleted the dep/pybids_0.9 branch July 13, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump up to pybids 0.9
2 participants