ENH: Revise plugin and workflow initialization #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Apr 20, 2022
| _plugin = { | ||
| "plugin": Plugin(plugin_args=config.nipype.plugin_args), | ||
| } | ||
| gc.collect() |
There was a problem hiding this comment.
What is this collecting that doesn't get cleaned up on L95?
There was a problem hiding this comment.
I don't know what L95 could be possibly be collecting so... this is to say, I'm happy either way and maybe there are some unused variables in the plugin implementation that this would catch. Honestly, IDK. Happy to remove if it feels superfluous.
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
|
Hello @oesteban, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2022-04-20 19:18:45 UTC |
effigies
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that confining the workflow creation within an isolated process does not meaningfully help with the VM allocation while increasing the complexity horribly.
On the other hand, the config file has been made considerably more lightweight by using importlib metadata to check versions instead of importing packages, and the plugin instance (MultiProc and LegacyMultiProc) are now created at earlier states so workers are initialized with smaller memory fingerprint.