FIX: MCRIBS auto surface reconstruction logic #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
changed the title
mgxd
force-pushed
the
fix/mcribs-no-segmentation
branch
from
ab70ba9
to
719a71f
Compare
Previously, `--surface-recon-method auto` would not take into account the presence of a previously computed segmentation when determining MCRIBS as the method, despite the workflow erroring down the line if there is not one provided.
…ambiguous options
mgxd
force-pushed
the
fix/mcribs-no-segmentation
branch
from
719a71f
to
ae0b008
Compare
mgxd
added a commit
that referenced
this pull request
Oct 3, 2024
24.1.0 (October 02, 2024) This new minor release includes a few bug fixes, such as excluding MCRIBS from surface reconstruction without a precomputed segmentation and ensuring generated derivatives are not masked, as well as improvements to reporting. * ENH: Add boilerplate, errors to report (#403) * ENH: Add age to session report (#402) * ENH: Improvements to age parsing (#395, #398) * FIX: MCRIBS auto surface reconstruction logic (#399) * FIX: Do not force masking of anatomicals when using `--derivatives` (#400) * MAINT: Revisit warnings filter (#396) * MAINT: Automate testing with tox (#404) * MAINT: Port over parser arguments and tests from fmriprep (#401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
--surface-recon-method autowould not take into account the presence of a previously computed segmentation when determining MCRIBS as the method, despite the workflow erroring down the line if there is notone provided.
When working on this, I realized there was not a very clear way to request no surface reconstruction be performed, so this also adds the
noneoption to--surface-recon-methodand deprecates a few ambiguous recon-all specific options (--force-reconalland--fs-no-reconall)