Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add DWI volume plot method #101

Merged
merged 6 commits into from
May 9, 2024

Conversation

jhlegarreta
Copy link
Collaborator

Add DWI volume plot method.

@jhlegarreta
Copy link
Collaborator Author

Test data missing in here: tested with ds000114 from openneuro. Probably too large (104 MB) to add it here. Let me know which other dMRI volume that you know we could use.

Add DWI volume plot method.
@effigies effigies force-pushed the RelocatePlotDWIFromEddy branch from c70e36d to 97a286e Compare May 8, 2024 13:39
@effigies
Copy link
Member

effigies commented May 8, 2024

Added a downsampled and truncated copy of the indicated file. 3.5MB, which seems a reasonably modest addition and will be excluded from wheels.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.45%. Comparing base (977f26a) to head (ba1f12a).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   58.43%   58.45%   +0.01%     
==========================================
  Files          22       22              
  Lines        2086     2094       +8     
  Branches      364      322      -42     
==========================================
+ Hits         1219     1224       +5     
- Misses        783      787       +4     
+ Partials       84       83       -1     
Flag Coverage Δ
unittests 58.45% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta
Copy link
Collaborator Author

jhlegarreta commented May 8, 2024

Added a downsampled and truncated copy of the indicated file. 3.5MB, which seems a reasonably modest addition and will be excluded from wheels.

Thanks for working on this Chris 💯. The bvals and bvecs have not been truncated, though, and even if the test is passing, the gradient direction may not correspond to the one that is displayed.

IMO best would be to rename the DWI test file to clearly state that its has been truncated (and to reduce confusion with the original image on OpenNeuro), and add the matching bval/bvec pair.

Can you please do this @effigies ?

@jhlegarreta
Copy link
Collaborator Author

Thanks Chris. Merging.

@jhlegarreta jhlegarreta merged commit a8b3927 into nipreps:main May 9, 2024
21 checks passed
@jhlegarreta jhlegarreta deleted the RelocatePlotDWIFromEddy branch May 9, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants