-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE: Transition to ruff
for code formatting
#114
STYLE: Transition to ruff
for code formatting
#114
Conversation
f667ee1
to
c4124fc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 58.45% 58.63% +0.18%
==========================================
Files 22 22
Lines 2094 2096 +2
Branches 322 365 +43
==========================================
+ Hits 1224 1229 +5
+ Misses 787 783 -4
- Partials 83 84 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c4124fc
to
de36988
Compare
A few notes:
Which is more comprehensive (?), as it runs all pre-commit hooks (not only ruff). Otherwise, we may need to add the So the same is probably happening across all
|
b282731
to
aee610d
Compare
Transition to `ruff` for code formatting in line with the rest of the `nipreps` repositories. Drop the flake8 `W503` rule, which is not implemented by `ruff`. Add a GHA workflow to ensure that contributions not complying with the style are detected. Format the source code accordingly.
aee610d
to
d8f3beb
Compare
@jhlegarreta Yes, let's ignore those for now. |
Transition to
ruff
for code formatting in line with the rest of thenipreps
repositories.Drop the flake8
W503
rule, which is not implemented byruff
.Add a GHA workflow to ensure that contributions not complying with the style are detected.
Format the source code accordingly.