Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: Annotate tools and reportlets.utils #147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

effigies
Copy link
Member

This is an initial effort at annotating nireports. This does expose some gaps in the nibabel type stubs that will need to be addressed.

LMK what you think.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 87.83784% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.29%. Comparing base (f0690a1) to head (8c18471).

Files with missing lines Patch % Lines
nireports/reportlets/utils.py 85.71% 3 Missing and 2 partials ⚠️
nireports/tools/ndimage.py 78.94% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   65.10%   64.29%   -0.81%     
==========================================
  Files          25       25              
  Lines        2642     2661      +19     
  Branches      415      365      -50     
==========================================
- Hits         1720     1711       -9     
- Misses        811      838      +27     
- Partials      111      112       +1     
Flag Coverage Δ
unittests 64.93% <87.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant