-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Allow different types of reportlets, not only BIDS-based #60
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 51.50% 54.97% +3.46%
==========================================
Files 17 17
Lines 1689 1788 +99
Branches 337 359 +22
==========================================
+ Hits 870 983 +113
+ Misses 743 728 -15
- Partials 76 77 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
6ed679e
to
1b9f397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall changes to the reporting code are very difficult to assess. Reviewing test_report.py
, the changes to the API seem like manageable generalizations.
I have reviewed the three sample reports in the CircleCI output, and they appear reasonable.
One small comment about a function that I couldn't quickly work out the behavior of by reading the code.
86bb37c
to
dff5659
Compare
Beefed up documentation and coverage, not limited to the |
Adds two new types of reportlets:
metadata
, which basically renders an input dictionary (possibly nested) formatted as a table (instead of just receiving a ".html" reportlet).custom
, which currently hard-wires two subtypes of custom reportlets: the error summary and the boilerplate.Limitations:
Extra:
Examples:
Towards: #57.