Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Purge pkg_resources, add data loader #85

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Dec 13, 2023

Enable nireports to be installed and tested on Python 3.12, which no longer bundles setuptools in its virtual environments.

Apparently we're advertising 3.12 support without testing it... Adding that in.

Updating CircleCI, since we weren't installing the package there. I don't think we need the big Docker image.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19e1536) 57.36% compared to head (87dc5d7) 57.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   57.36%   57.36%           
=======================================
  Files          22       22           
  Lines        2024     2024           
  Branches      394      359   -35     
=======================================
  Hits         1161     1161           
  Misses        782      782           
  Partials       81       81           
Flag Coverage Δ
unittests 57.14% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

@celprov @oesteban @mgxd I'm comfortable merging this tomorrow without review, but feel free to have a look.

Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I am once again advocating for a standalone nipreps Loader package 😄

@effigies effigies merged commit a28346b into nipreps:main Dec 13, 2023
21 checks passed
@effigies effigies deleted the enh/data branch December 13, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants