-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF: Purge pkg_resources, add data loader #85
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 57.36% 57.36%
=======================================
Files 22 22
Lines 2024 2024
Branches 394 359 -35
=======================================
Hits 1161 1161
Misses 782 782
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I am once again advocating for a standalone nipreps Loader package 😄
Enable nireports to be installed and tested on Python 3.12, which no longer bundles setuptools in its virtual environments.
Apparently we're advertising 3.12 support without testing it... Adding that in.
Updating CircleCI, since we weren't installing the package there. I don't think we need the big Docker image.