FIX: Ensure data type of masked image matches T1.mgz

[effigies]

Fix for nipreps/fmriprep#1890.

FreeSurfer anatomical images are scaled to uint8s, so coercing to float was problematic.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     FIX: Ensure data type of masked image matches T1.mgz

     TEST: Smoke-test FSInjectBrainExtracted interface

Powered by Pull Assistant. Last update ce124ee ... 6668785. Read the comment docs.

[codecov]

Codecov Report

Merging #430 into master will increase coverage by 12.86%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #430       +/-   ##
===========================================
+ Coverage   42.88%   55.74%   +12.86%     
===========================================
  Files          56       57        +1     
  Lines        5396     5410       +14     
  Branches        0      633      +633     
===========================================
+ Hits         2314     3016      +702     
+ Misses       3082     2340      -742     
- Partials        0       54       +54

Flag	Coverage Δ
#reportlettests	100% <ø> (ø)	⬆️
#unittests	43.36% <100%> (+0.48%)	⬆️

Impacted Files	Coverage Δ
niworkflows/interfaces/freesurfer.py	51.63% <100%> (+7.37%)	⬆️
niworkflows/interfaces/tests/test_freesurfer.py	100% <100%> (ø)
niworkflows/interfaces/registration.py	52.15% <0%> (+3.44%)	⬆️
niworkflows/interfaces/plotting.py	84.74% <0%> (+10.16%)	⬆️
niworkflows/interfaces/mni.py	42.28% <0%> (+16.57%)	⬆️
niworkflows/interfaces/masks.py	62.87% <0%> (+18.56%)	⬆️
niworkflows/interfaces/report_base.py	68.85% <0%> (+21.31%)	⬆️
niworkflows/viz/plots.py	46.31% <0%> (+39.69%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5512b8e...6668785. Read the comment docs.

[pep8speaks]

Hello @effigies, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 niworkflows.

Comment last updated at 2019-11-27 20:21:44 UTC