Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Check for in_segm input, not seg_file (typo) #592

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

effigies
Copy link
Member

Introduced in 1.2.0rc2. in maint/1.2.x, to be merged into maint/1.3.x and master on completion.

Identified by GitHub user @hrswearingen in nipreps/mriqc#867.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #592 (dc4c9f0) into maint/1.2.x (c5432fb) will increase coverage by 3.59%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.2.x     #592      +/-   ##
===============================================
+ Coverage        48.14%   51.74%   +3.59%     
===============================================
  Files               42       43       +1     
  Lines             5269     5280      +11     
  Branches           770      770              
===============================================
+ Hits              2537     2732     +195     
+ Misses            2652     2451     -201     
- Partials            80       97      +17     
Flag Coverage Δ
documentation 33.86% <ø> (?)
reportlettests 100.00% <ø> (ø)
unittests 48.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/interfaces/plotting.py 75.00% <ø> (ø)
niworkflows/__init__.py 81.81% <0.00%> (ø)
niworkflows/interfaces/report_base.py 49.18% <0.00%> (+1.63%) ⬆️
niworkflows/interfaces/utils.py 42.75% <0.00%> (+2.61%) ⬆️
niworkflows/interfaces/fixes.py 52.94% <0.00%> (+5.88%) ⬆️
niworkflows/anat/skullstrip.py 80.00% <0.00%> (+50.00%) ⬆️
niworkflows/anat/freesurfer.py 91.30% <0.00%> (+52.17%) ⬆️
niworkflows/anat/ants.py 69.61% <0.00%> (+57.45%) ⬆️
niworkflows/func/util.py 87.50% <0.00%> (+62.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5432fb...dc4c9f0. Read the comment docs.

@oesteban oesteban merged commit 4db7c02 into maint/1.2.x Dec 14, 2020
@oesteban oesteban deleted the fix/seg_file_input branch December 14, 2020 11:06
@oesteban oesteban restored the fix/seg_file_input branch December 14, 2020 11:06
@effigies
Copy link
Member Author

Cascaded up into maint/1.3.x and master. Not sure what all series need releasing.

@effigies effigies deleted the fix/seg_file_input branch December 14, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants