FIX: Improve mask contour visibility #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
- Coverage 49.02% 48.00% -1.02%
==========================================
Files 45 45
Lines 5520 5516 -4
Branches 795 791 -4
==========================================
- Hits 2706 2648 -58
- Misses 2713 2774 +61
+ Partials 101 94 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
oesteban
reviewed
Jun 14, 2021
| @@ -367,7 +367,7 @@ def plot_registration( | |||
| display.add_contours(white, colors="b", **kwargs) | |||
| display.add_contours(pial, colors="r", **kwargs) | |||
| elif contour is not None: | |||
| display.add_contours(contour, colors="b", levels=[0.5], linewidths=0.5) | |||
| display.add_contours(contour, colors="r", levels=[0.5], linewidths=0.5) | |||
There was a problem hiding this comment.
this will clobber the pial (line 368), can we find some better color?
There was a problem hiding this comment.
those should be mutually exclusive, since it's an if elif block no?
oesteban
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the mask outline from blue to red, for increased contrast.