-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add affine_tolerance
flag to MergeSeries
#706
Conversation
Hello @mgxd, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2022-04-08 19:50:29 UTC |
Codecov Report
@@ Coverage Diff @@
## maint/1.4.x #706 +/- ##
===============================================
+ Coverage 45.94% 49.18% +3.23%
===============================================
Files 46 49 +3
Lines 5641 5866 +225
Branches 809 837 +28
===============================================
+ Hits 2592 2885 +293
+ Misses 2962 2872 -90
- Partials 87 109 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. I'd make the default threshold explicit.
78e3f5b
to
fd3bf89
Compare
@mgxd sorry to do this, but we're going to need this in |
fd3bf89
to
de1593c
Compare
Sounds good - I changed the PR to target 1.4.x |
Thanks. It did pass, so I'm going to go ahead and merge. |
This should help clear up the error found in nipreps/fmriprep#2706