-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Port GIFTI/CIFTI interfaces from fMRIPrep #811
Conversation
Co-authored-by: Christopher J. Markiewicz <effigies@gmail.com>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
==========================================
+ Coverage 62.31% 62.78% +0.46%
==========================================
Files 50 52 +2
Lines 5987 6204 +217
Branches 887 910 +23
==========================================
+ Hits 3731 3895 +164
- Misses 2074 2122 +48
- Partials 182 187 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly skimmed over the workbench; given that you gave it a thorough read-through after I wrote it, I'm comfortable with it as long as you just copied. If you made any changes you want reviewed, could you highlight them?
Made some suggestions to improve the documentation in the Python GIFTI interface.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Nope, no changes |
Cool. Since all changes just merged are in docstrings or comments, I will merge without wasting CI cycles. |
Bring in interfaces introduced in nipreps/fmriprep#3011