Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Port GIFTI/CIFTI interfaces from fMRIPrep #811

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Jun 7, 2023

Bring in interfaces introduced in nipreps/fmriprep#3011

mgxd and others added 2 commits June 7, 2023 12:08
@mgxd mgxd requested a review from effigies June 7, 2023 16:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch coverage: 75.57% and project coverage change: +0.46 🎉

Comparison is base (c2d46e1) 62.31% compared to head (3b570d0) 62.78%.

❗ Current head 3b570d0 differs from pull request most recent head f4ac201. Consider uploading reports for the commit f4ac201 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   62.31%   62.78%   +0.46%     
==========================================
  Files          50       52       +2     
  Lines        5987     6204     +217     
  Branches      887      910      +23     
==========================================
+ Hits         3731     3895     +164     
- Misses       2074     2122      +48     
- Partials      182      187       +5     
Flag Coverage Δ
reportlettests ∅ <ø> (∅)
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/utils/bids.py 76.19% <ø> (ø)
niworkflows/interfaces/surf.py 47.00% <41.66%> (-0.47%) ⬇️
niworkflows/interfaces/workbench.py 77.24% <77.24%> (ø)
niworkflows/interfaces/conftest.py 96.15% <96.15%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly skimmed over the workbench; given that you gave it a thorough read-through after I wrote it, I'm comfortable with it as long as you just copied. If you made any changes you want reviewed, could you highlight them?

Made some suggestions to improve the documentation in the Python GIFTI interface.

niworkflows/interfaces/surf.py Outdated Show resolved Hide resolved
niworkflows/interfaces/surf.py Outdated Show resolved Hide resolved
niworkflows/interfaces/surf.py Outdated Show resolved Hide resolved
niworkflows/interfaces/surf.py Outdated Show resolved Hide resolved
niworkflows/interfaces/surf.py Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@mgxd
Copy link
Contributor Author

mgxd commented Jun 9, 2023

Nope, no changes

@effigies
Copy link
Member

effigies commented Jun 9, 2023

Cool. Since all changes just merged are in docstrings or comments, I will merge without wasting CI cycles.

@effigies effigies merged commit 83bb10e into nipreps:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants