RF: Replace Convert3d with nitransforms in MCFLIRT2ITK #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
enh/nitransforms-mat2itk
branch
from
1bb630a
to
34314d2
Compare
effigies
force-pushed
the
enh/nitransforms-mat2itk
branch
from
34314d2
to
d727ef7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 63.09% 63.36% +0.26%
==========================================
Files 53 53
Lines 6249 6237 -12
Branches 913 907 -6
==========================================
+ Hits 3943 3952 +9
+ Misses 2119 2099 -20
+ Partials 187 186 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c3d_affine_tool is a pretty heavy dependency when we have
nitransforms. This PR removes it, while adding a regression test to make sure that values stay unchanged.I added a couple transform matrices and the header of an actual boldref to ensure that the test doesn't depend on trivial invariants, but it's not an exhaustive test.