Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow alternative extensions when creating a BIDS skeleton #858

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Feb 27, 2024

This allows creating non-nii.gz files through generate_bids_skeleton. If no extension is provided, .nii.gz will still be used as the default.

niworkflows/utils/testing.py Outdated Show resolved Hide resolved
niworkflows/utils/testing.py Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (bbe6170) to head (1958365).

❗ Current head 1958365 differs from pull request most recent head e62aa9b. Consider uploading reports for the commit e62aa9b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
- Coverage   60.96%   60.93%   -0.04%     
==========================================
  Files          55       55              
  Lines        6558     6558              
  Branches      954      954              
==========================================
- Hits         3998     3996       -2     
- Misses       2374     2380       +6     
+ Partials      186      182       -4     
Flag Coverage Δ
reportlettests ∅ <ø> (?)
unittests ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd merged commit 6edfb38 into nipreps:master Feb 27, 2024
7 of 10 checks passed
@mgxd mgxd deleted the add/bids-layout-extension branch February 27, 2024 22:00
effigies added a commit that referenced this pull request Apr 17, 2024
1.10.1 (March 06, 2024)

Bug-fix release in the 1.10.x series

* ENH: Allow alternative ``extensions`` when creating a BIDS skeleton (#858)
* ENH: Parsing for ``space+cohort`` structure (#857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants