STY: Apply assorted ruff/refurb rules #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
refurb
branch
from
9c89d11 to
2c368a4
Compare
effigies
reviewed
Apr 17, 2024
FURB118 Use `operator.or_` instead of defining a lambda FURB118 Use `operator.add` instead of defining a lambda
FURB148 `enumerate` index is unused, use `for x in y` instead
FURB168 Prefer `is` operator over `isinstance` to check if an object is `None`
DimitriPapadopoulos
force-pushed
the
refurb
branch
from
2c368a4 to
e86f079
Compare
effigies
approved these changes
Apr 17, 2024
effigies
changed the title
effigies
pushed a commit
that referenced
this pull request
Jun 10, 2024
* STY: Apply ruff/refurb rule (FURB118) FURB118 Use `operator.or_` instead of defining a lambda FURB118 Use `operator.add` instead of defining a lambda * STY: Apply ruff/refurb rule (FURB148) FURB148 `enumerate` index is unused, use `for x in y` instead * STY: Apply ruff/refurb rule (FURB168) FURB168 Prefer `is` operator over `isinstance` to check if an object is `None`
effigies
added a commit
that referenced
this pull request
Jun 10, 2024
1.10.2 (June 10, 2024) Bug-fix release in the 1.10.x series * ENH: Modify FSSource to output T2 (#868) * STY: Apply ruff/flake8-implicit-str-concat rule ISC001 (#870) * STY: Remove extraneous quotes (#859) * STY: Apply assorted ruff/refurb rules (#867) * MNT: update vendored docs files (#834) * MNT: Fix deprectation error in CI (#866)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.