Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check 2D spaces against list from templateflow #888

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

tsalo
Copy link
Contributor

@tsalo tsalo commented Aug 5, 2024

Closes #882.

Changes proposed:

  • To determine dimensionality of a reference space (i.e., surface vs. volume), build a list of 2D standard spaces from templateflow by searching for spaces with a sphere file. I also added a constant list of 2D non-standard spaces to check against, although it's currently just fsnative.
    • The old way looked at the start of the space's name and checked if it began with fs, which works for fsnative, fsaverage, and fsLR, but not for onavg, dhcpSym, or dhcpAsym.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.45%. Comparing base (d44bae0) to head (9851ee9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   71.44%   71.45%   +0.01%     
==========================================
  Files          87       87              
  Lines        8397     8400       +3     
  Branches      990      990              
==========================================
+ Hits         5999     6002       +3     
  Misses       2390     2390              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Contributor Author

tsalo commented Aug 5, 2024

@effigies or @mgxd would one of you be willing to review this?

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@effigies effigies merged commit 1f9a0cf into nipreps:master Aug 5, 2024
26 checks passed
@tsalo tsalo deleted the fix-dim branch August 6, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dim attribute in References is incorrect for non-Freesurfer surfaces
2 participants