Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Use keys.openpgp.org over sks-keyservers #223

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 5, 2021

Closes #220 for master. Need to backport correctly (see #222).

@mgxd
Copy link
Contributor

mgxd commented Aug 5, 2021

well, at least it's past the keyserver error 😆

Actually, I'm not sure that resolved correctly
Executing: /tmp/apt-key-gpghome.Jq92HIgpFJ/gpg.1.sh --recv-keys --keyserver hkps://keys.openpgp.org 0xA5D32F012649A5A9
gpg: key A5D32F012649A5A9: new key but contains no user ID - skipped
gpg: Total number processed: 1
gpg:           w/o user IDs: 1
0% [Working]Get:1 http://security.debian.org/debian-security buster/updates InRelease [65.4 kB]
0% [Waiting for headers] [1 InRelease 0 B/65.4 kB 0%] [Connecting to neurodeb.pGet:2 http://deb.debian.org/debian buster InRelease [122 kB]                   
0% [2 InRelease 0 B/122 kB 0%] [1 InRelease 42.8 kB/65.4 kB 65%] [Connecting to0% [2 InRelease 122 kB/122 kB 100%] [Connecting to neurodeb.pirsquared.org (208Get:3 http://deb.debian.org/debian buster-updates InRelease [51.9 kB]          
Get:4 http://neurodeb.pirsquared.org data InRelease [30.2 kB]                  
0% [4 InRelease 30.2 kB/30.2 kB 100%]                                          0% [Working]                         Get:5 http://neurodeb.pirsquared.org focal InRelease [18.2 kB]
0% [5 InRelease 0 B/18.2 kB 0%]0% [Working]                   0% [Working]Get:6 http://security.debian.org/debian-security buster/updates/main amd64 Packages [299 kB]
0% [6 Packages 0 B/299 kB 0%]0% [Working]                 0% [6 Packages store 0 B]0% [Working]             0% [Working]Get:7 http://deb.debian.org/debian buster/main amd64 Packages [7907 kB]
0% [7 Packages 21.3 kB/7907 kB 0%]0% [Working]                      0% [7 Packages store 0 B]0% [7 Packages store 0 B]Get:8 http://deb.debian.org/debian buster-updates/main amd64 Packages [15.2 kB]
0% [7 Packages store 0 B] [8 Packages 15.2 kB/15.2 kB 100%]0% [7 Packages store 0 B]                                  Err:4 http://neurodeb.pirsquared.org data InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY A5D32F012649A5A9
0% [7 Packages store 0 B]Err:5 http://neurodeb.pirsquared.org focal InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY A5D32F012649A5A9
92% [7 Packages store 0 B]92% [7 Packages store 0 B]94% [Working]             94% [8 Packages store 0 B]96% [Working]             Reading package lists... Done
W: GPG error: http://neurodeb.pirsquared.org data InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY A5D32F012649A5A9
E: The repository 'http://neurodeb.pirsquared.org data InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
W: GPG error: http://neurodeb.pirsquared.org focal InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY A5D32F012649A5A9
E: The repository 'http://neurodeb.pirsquared.org focal InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
CircleCI received exit code 0

@effigies
Copy link
Member Author

effigies commented Aug 5, 2021

We have the key: https://github.com/nipreps/sdcflows/blob/master/.docker/files/neurodebian.gpg

Why aren't we just using that?

@codecov-commenter
Copy link

Codecov Report

Merging #223 (6959b3c) into master (d2023f5) will increase coverage by 3.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   93.54%   97.08%   +3.54%     
==========================================
  Files          24       24              
  Lines        1642     1647       +5     
  Branches      191      191              
==========================================
+ Hits         1536     1599      +63     
+ Misses         81       25      -56     
+ Partials       25       23       -2     
Flag Coverage Δ
travis 88.76% <ø> (?)
unittests 97.07% <ø> (+3.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/utils/bimap.py 100.00% <0.00%> (ø)
sdcflows/fieldmaps.py 99.40% <0.00%> (+0.01%) ⬆️
sdcflows/transform.py 97.61% <0.00%> (+0.02%) ⬆️
sdcflows/interfaces/utils.py 98.26% <0.00%> (+17.34%) ⬆️
sdcflows/interfaces/brainmask.py 100.00% <0.00%> (+43.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2023f5...6959b3c. Read the comment docs.

@mgxd mgxd merged commit 794f036 into nipreps:master Aug 6, 2021
@effigies effigies deleted the mnt/drop_sks branch August 19, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: cache_test_data job failing
3 participants