Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add optional session distinction to wrangler #261

Merged
merged 1 commit into from
May 13, 2022

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Jan 24, 2022

In the same vein as nipreps/niworkflows#678

@mgxd mgxd force-pushed the enh/wrangle-sessions branch from 836da7c to ad761df Compare March 29, 2022 19:50
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #261 (324d89b) into master (d245dfd) will increase coverage by 4.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   83.09%   87.35%   +4.26%     
==========================================
  Files          25       25              
  Lines        1851     1850       -1     
  Branches      278      278              
==========================================
+ Hits         1538     1616      +78     
+ Misses        281      204      -77     
+ Partials       32       30       -2     
Flag Coverage Δ
travis 83.08% <100.00%> (-0.01%) ⬇️
unittests 87.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/utils/wrangler.py 97.53% <100.00%> (-0.04%) ⬇️
sdcflows/workflows/outputs.py 93.54% <0.00%> (+1.61%) ⬆️
sdcflows/interfaces/reportlets.py 89.83% <0.00%> (+1.69%) ⬆️
sdcflows/interfaces/bspline.py 87.44% <0.00%> (+4.18%) ⬆️
sdcflows/interfaces/fmap.py 87.35% <0.00%> (+14.94%) ⬆️
sdcflows/workflows/fit/syn.py 69.82% <0.00%> (+21.30%) ⬆️
sdcflows/utils/phasemanip.py 94.02% <0.00%> (+28.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d245dfd...324d89b. Read the comment docs.

@mgxd mgxd requested review from oesteban and effigies May 12, 2022 18:12
@mgxd
Copy link
Contributor Author

mgxd commented May 12, 2022

this will be needed for nipreps/nibabies#193 - could I get a quick review?

@effigies
Copy link
Member

Bumping CI to make sure things haven't broken...

@effigies effigies closed this May 12, 2022
@effigies effigies reopened this May 12, 2022
@effigies
Copy link
Member

And naturally they broke.

@mgxd
Copy link
Contributor Author

mgxd commented May 12, 2022

Yeah I would guess master is broken - this is what I was trying to fix in #269

@mgxd mgxd force-pushed the enh/wrangle-sessions branch from ad761df to 324d89b Compare May 13, 2022 15:49
@mgxd mgxd merged commit e92373d into nipreps:master May 13, 2022
@mgxd mgxd deleted the enh/wrangle-sessions branch May 13, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants