Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Ensure builds are triggered weekly #270

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented May 13, 2022

No description provided.

@effigies
Copy link
Member

Is this to keep the cache from expiring? If not, maybe we should drop cache so we're not surprised by mismatches between master and PRs?

@mgxd
Copy link
Contributor Author

mgxd commented May 13, 2022

is there an easy way to specify a stale cache on GHA? I agree dropping the cache can be helpful (just came up in #269) but might be excessive doing it every build

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Base: 83.94% // Head: 90.74% // Increases project coverage by +6.80% 🎉

Coverage data is based on head (b49f5e7) compared to base (07ee004).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   83.94%   90.74%   +6.80%     
==========================================
  Files          24       24              
  Lines        1999     1999              
  Branches      232      304      +72     
==========================================
+ Hits         1678     1814     +136     
+ Misses        280      145     -135     
+ Partials       41       40       -1     
Flag Coverage Δ
travis 83.94% <ø> (ø)
unittests 90.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/workflows/outputs.py 93.84% <0.00%> (+1.53%) ⬆️
sdcflows/interfaces/reportlets.py 89.83% <0.00%> (+1.69%) ⬆️
sdcflows/interfaces/bspline.py 80.64% <0.00%> (+3.22%) ⬆️
sdcflows/interfaces/utils.py 90.86% <0.00%> (+10.04%) ⬆️
sdcflows/workflows/fit/syn.py 69.82% <0.00%> (+21.30%) ⬆️
sdcflows/interfaces/fmap.py 96.55% <0.00%> (+24.13%) ⬆️
sdcflows/utils/phasemanip.py 94.02% <0.00%> (+28.35%) ⬆️
sdcflows/interfaces/brainmask.py 100.00% <0.00%> (+43.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member

My guess would be adding something that changes periodically to the cache name, like ${{ date.week }} (I just made that up).

@effigies
Copy link
Member

effigies commented Dec 3, 2022

Well, we can worry about better cache names later. Sorry for dropping the ball on this one, which is clearly a good idea on its own.

@effigies effigies merged commit a2bc54c into nipreps:master Dec 3, 2022
@effigies effigies added this to the 2.2.0 milestone Dec 6, 2022
effigies pushed a commit to effigies/sdcflows that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants