Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Make wrangler more verbose #284

Merged
merged 9 commits into from
Oct 10, 2022
Merged

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Sep 26, 2022

Closes #283

Adds verbose parameter, which enables logging through the find_estimators() process.

I think this could also benefit from a way to visualize the layout, to further help debug why files are not being found.

@mgxd mgxd requested a review from oesteban September 26, 2022 21:25
@mgxd mgxd force-pushed the enh/verbose-wrangler branch from 151192b to 67cab9e Compare September 27, 2022 02:10
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Base: 83.12% // Head: 87.26% // Increases project coverage by +4.13% 🎉

Coverage data is based on head (54233eb) compared to base (6061ed8).
Patch coverage: 97.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   83.12%   87.26%   +4.13%     
==========================================
  Files          26       25       -1     
  Lines        1956     1979      +23     
  Branches      295      297       +2     
==========================================
+ Hits         1626     1727     +101     
+ Misses        295      219      -76     
+ Partials       35       33       -2     
Flag Coverage Δ
travis 83.27% <97.87%> (+0.14%) ⬆️
unittests 87.16% <97.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/utils/wrangler.py 97.11% <97.14%> (-0.42%) ⬇️
sdcflows/cli/find_estimators.py 88.88% <100.00%> (+0.25%) ⬆️
sdcflows/utils/misc.py 100.00% <100.00%> (ø)
sdcflows/__init__.py
sdcflows/workflows/outputs.py 93.54% <0.00%> (+1.61%) ⬆️
sdcflows/interfaces/reportlets.py 89.83% <0.00%> (+1.69%) ⬆️
sdcflows/interfaces/bspline.py 88.00% <0.00%> (+4.00%) ⬆️
sdcflows/interfaces/fmap.py 87.35% <0.00%> (+14.94%) ⬆️
sdcflows/workflows/fit/syn.py 69.82% <0.00%> (+21.30%) ⬆️
sdcflows/utils/phasemanip.py 94.02% <0.00%> (+28.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would allow fMRIPrep and such to pass in their own logger objects.

sdcflows/utils/wrangler.py Outdated Show resolved Hide resolved
sdcflows/utils/wrangler.py Outdated Show resolved Hide resolved
sdcflows/utils/wrangler.py Outdated Show resolved Hide resolved
sdcflows/utils/wrangler.py Outdated Show resolved Hide resolved
sdcflows/utils/wrangler.py Show resolved Hide resolved
sdcflows/cli/find_estimators.py Outdated Show resolved Hide resolved
@mgxd mgxd merged commit 3479668 into nipreps:master Oct 10, 2022
@mgxd mgxd deleted the enh/verbose-wrangler branch October 10, 2022 13:41
@effigies effigies added this to the 2.2.0 milestone Dec 6, 2022
effigies pushed a commit to effigies/sdcflows that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve debug verbosity of find_estimators
4 participants